This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the template literal type parsing by restricting the capture of inner types to just the "template_type" syntax node, addressing an issue where "string_fragment" nodes were incorrectly captured.
- Restricts inner type capture for template literal types
- Adds a test case to verify the change
Files not reviewed (1)
- languages/tree-sitter-stack-graphs-typescript/src/stack-graphs.tsg: Language not supported
Contributor
|
The github/stack-graphs repository is no longer being maintained. As per #502, I'm closing all issues and pull requests before archiving the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stanza dealing
template_literal_typesyntax nodes is too liberal in its capturing of inner types, causing it to capturestring_fragmentsyntax nodes and fail creating edges with an error like:Restricting the inner type capture to just
template_typesyntax node fixes the issue. As of v0.23.2 of the Tree-sitter TypeScript grammar thetemplate_literal_typeonly allowsstring_fragmentandtemplate_typechildren, so this fix should be fine. Copious testing (on this repo’s TypeScript test suite and on all of microsoft/vscode) reveals no negative side effects.