This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the deep property access issue in TypeScript by separating graph nodes and edge creation to prevent errors when dealing with nested member expressions.
- Added tests to cover various deep property access cases (normal, parenthesized, and subscript expressions).
- The changes in the tests file validate that the error no longer occurs with non-matching inner syntax nodes.
Files not reviewed (1)
- languages/tree-sitter-stack-graphs-typescript/src/stack-graphs.tsg: Language not supported
| // ^ defined: 8 | ||
| } | ||
|
|
||
| { /// Deep with arenthesized expression |
There was a problem hiding this comment.
The comment contains a spelling error 'arenthesized'; please change it to 'parenthesized' for clarity.
Suggested change
| { /// Deep with arenthesized expression | |
| { /// Deep with parenthesized expression |
bm-w
force-pushed
the
bm-w/fix-typescript-deep-property-access
branch
from
1654924 to
12b03af
Compare
|
I ran into this playing around with stack graphs. What's the time-line like for this (and the other fixes) being merged and/or released? |
Contributor
|
The github/stack-graphs repository is no longer being maintained. As per #502, I'm closing all issues and pull requests before archiving the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of stanzas were only matching
member_expressionsyntax nodes that had as theirobject:field either anothermember_expressionor anidentifiersyntax node. E.g.:However, if that object was itself a
member_expressionthe stanzas would create edges to itsexpr_[dr]efgraph nodes indiscriminately, regardless of whether it would itself be matched and thus those nodes created. In a “deep” property access involving two nestedmember_expressions and a third non-matching inner syntax node, e.g. aparenthesized_expression, these stanzas would cause errors, e.g.:The fragment of the parsed Tree-sitter tree for such a deep property access is:
Separating graph nodes and edges creation fixes the issue. Copious testing (on our TS test suite and on all of microsoft/vscode) reveals no negative side effects.