This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Fix superclass keyword arguments in Python.#480
Closed
bm-w wants to merge 1 commit intogithub:mainfrom
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with how Python superclass keyword arguments are handled by updating the captured nodes to only include valid superclass expressions.
- Updated test file to include a subclass with a keyword argument in its superclass list.
- Adjusted inline comments to reflect the updated definition line numbers.
Files not reviewed (1)
- languages/tree-sitter-stack-graphs-python/src/stack-graphs.tsg: Language not supported
Contributor
|
The github/stack-graphs repository is no longer being maintained. As per #502, I'm closing all issues and pull requests before archiving the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python supports keyword arguments in its
superclasses: (argument_list …), which somehow modify the superclass. The stanza capturing superclasses was erroneously capturing these keyword arguments as superclasses themselves as well, which would then cause an error upon emitting the edge:The fragment of the parsed Tree-sitter tree for such a superclass argument list with keyword arguments is:
As of v0.23.5 of the Python grammar, the
superclassesfield is indeed anargument_listsyntax node, which in turn can contain either anexpressionor akeyword_argument(among other things), andexpressionin turn can be a whole host of types of syntax nodes.Explicitly capturing only
identifierandattribute(which are dotted identifier chains likefoo.bar) syntax nodes fixes the issue. This is possibly too strict, since technically any expression can be used here, but it likely captures the vast majority of cases out there.