Skip to content

Fix casing issue in new item value #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
muan merged 2 commits into from
Dec 10, 2019
Merged

Fix casing issue in new item value #2

muan merged 2 commits into from
Dec 10, 2019

Conversation

@muan
Copy link
Contributor

@muan muan commented Dec 10, 2019 •
edited
Loading

This ensures that the user/app facing query we use and distribute has its original casing. This fixes items always being created in lower case.

This all ensures that if an app wants to implement case-sensitive casing they can. Currently they would get .toLowerCase() item text and query in the filter function, which isn't ideal.

cc @srt32

@muan muan requested a review from a team December 10, 2019 20:09
@muan muan merged commit 9e07ccc into master Dec 10, 2019
@muan muan deleted the casing branch December 10, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dgraham dgraham dgraham approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@muan @dgraham