fix(python): correct PermissionHandler.approve_all type annotations#618
Open
giulio-leone wants to merge 1 commit intogithub:mainfrom
Open
fix(python): correct PermissionHandler.approve_all type annotations#618giulio-leone wants to merge 1 commit intogithub:mainfrom
giulio-leone wants to merge 1 commit intogithub:mainfrom
Conversation
The approve_all static method used untyped parameters (Any) and returned a plain dict, conflicting with the _PermissionHandlerFn signature that expects (PermissionRequest, dict[str, str]) -> PermissionRequestResult. - Replace parameter types: Any → PermissionRequest, dict[str, str] - Replace return type: dict → PermissionRequestResult - Use PermissionRequestResult() constructor instead of dict literal Fixes github#612 Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Python SDK’s built-in PermissionHandler.approve_all helper to have type annotations consistent with the _PermissionHandlerFn callback signature expected by SessionConfig.on_permission_request, resolving the type-checker mismatch reported in #612.
Changes:
- Tighten
approve_allparameter types fromAnytoPermissionRequestanddict[str, str]. - Update
approve_allreturn type fromdicttoPermissionRequestResult. - Construct the result using
PermissionRequestResult(kind="approved")rather than a plain dict literal.
Author
|
Thanks for the review — accurate summary of the type annotation improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #612
PermissionHandler.approve_allusedAnyparameter types and returned a plaindict, conflicting with the_PermissionHandlerFnsignature:Changes
Any→PermissionRequest,dict[str, str]dict→PermissionRequestResultPermissionRequestResult()constructor instead of dict literalBefore
After
Tests