Shared: Add library for unbound lists #21060
Open
+162
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
shared/unbound-list
branch
from
ed02c2c to
08339fe
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts the unbound list implementation from the type inference library into a new reusable module. The unbound list data structure represents lists as encoded strings and is useful in performance-critical scenarios where a newtype representation is not feasible.
Key Changes:
- Created new shared library
shared/util/codeql/util/UnboundList.qllwith generic unbound list implementation - Refactored
TypePathin type inference to use the new genericUnboundListmodule
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
shared/util/codeql/util/UnboundList.qll |
New module providing generic unbound list implementation with string encoding, supporting list operations like append, cons, and decomposition |
shared/typeinference/codeql/typeinference/internal/TypeInference.qll |
Refactored to use the new UnboundList module, replacing the previous inline TypePath implementation with a cleaner instantiation of the generic library |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from the shared type inference library, as we will have another use of unbound lists in #20987.