Conversation
egilmorez
reviewed
Jan 25, 2019
| * Retrieve a valid access token that can be use to authorize requests to the Remote Config REST | ||
| * API. | ||
| * | ||
| * This method assumes it is either running in a trusted Google environment like GCP or if running |
There was a problem hiding this comment.
Does "it" refer to the server? Suggest disambiguating.
Contributor
|
@kroikie I'm just gonna review the |
Contributor
Author
|
@samtstern |
Contributor
Author
|
Will only merge when documentation that uses these snippets are ready. |
hiranya911
suggested changes
Sep 30, 2019
| private static String getAccessToken() throws IOException { | ||
| GoogleCredential googleCredential = GoogleCredential | ||
| .fromStream(new FileInputStream("service-account.json")) | ||
| GoogleCredential googleCredential = GoogleCredential.getApplicationDefault() |
Contributor
There was a problem hiding this comment.
Should probably use com.google.auth.oauth2.GoogleCredentials here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update config quickstart to use default application credential which is best practice for server side Firebase authentication.