Fix a small bug in setCustomUserClaims() auth snippet#747
Merged
Conversation
prameshj
reviewed
Dec 8, 2022
src/test/java/com/google/firebase/snippets/FirebaseAuthSnippets.java
Outdated
Show resolved
Hide resolved
…omUserClaimsTenant
prameshj
approved these changes
Dec 8, 2022
pragatimodi
approved these changes
Dec 10, 2022
lahirumaramba
approved these changes
Dec 13, 2022
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Thanks @NhienLam ! LGTM!
Member
|
@prameshj @kevinthecheung Should we also add Java code samples to https://cloud.google.com/identity-platform/docs/multi-tenancy-managing-tenants#controlling_access_with_custom_claims ? |
Contributor
Author
|
@lahirumaramba Thanks for approving the PR!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing the code snippets in FirebaseAuthSnippets.java, which would be used this doc https://cloud.google.com/identity-platform/docs/multi-tenancy-managing-tenants#controlling_access_with_custom_claims. When testing the setCustomUserClaims(), I got an USER_NOT_FOUND error.
"No user record found for the given identifier (USER_NOT_FOUND)."
I believe this error happens because
FirebaseAuth.getInstance()doesn’t specify which tenant we are setting.Therefore, using TenantAwareAuth instance for the corresponding tenant
tenantAuthinstead ofFirebaseAuth.getInstance()fixes the issue.