Skip to content

docs: Add comprehensive type system reference with Map type support #5855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
franciscojavierarceo merged 2 commits into from
Jan 14, 2026
Merged

docs: Add comprehensive type system reference with Map type support #5855

franciscojavierarceo merged 2 commits into from
Jan 14, 2026

Conversation

Copy link
Contributor

Copilot AI commented Jan 14, 2026 •
edited
Loading

What this PR does / why we need it:

Map types were added in PR #5772 but documentation only mentioned them briefly in one sentence. This PR provides comprehensive type system documentation with tables and working examples.

Added type reference tables:

  • Primitive types (Int32, Int64, Float32, Float64, String, Bytes, Bool, UnixTimestamp)
  • Array types (all list variants)
  • Map types (Map, Array(Map)) with key/value constraints

Complete feature view example:

from feast import Entity, FeatureView, Field, FileSource
from feast.types import Int32, Float64, String, Array, Map

user_features = FeatureView(
    name="user_features",
    entities=[user],
    schema=[
        # All primitive types demonstrated
        Field(name="age", dtype=Int32),
        Field(name="credit_score", dtype=Float64),
        
        # Array types
        Field(name="daily_steps", dtype=Array(Int32)),
        
        # Map types
        Field(name="user_preferences", dtype=Map),
        Field(name="activity_log", dtype=Array(Map)),
    ],
    source=user_features_source,
)

Map usage examples:

  • Simple maps: {"theme": "dark", "font_size": 14}
  • Nested maps: {"profile": {"bio": "...", "location": "..."}}
  • Lists of maps: [{"action": "login", "timestamp": "..."}, ...]

Which issue(s) this PR fixes:

Related to #5772 (Map type support implementation)

Misc

Documentation-only change. No code modifications.

Original prompt

This section details on the original issue you should resolve

<issue_title>feat: Support for Map value data type</issue_title>
<issue_description>Is your feature request related to a problem? Please describe.
Want to support map typed feature value in offline and online feature store.

Describe the solution you'd like
Since dict can be mapped to map type, then could be supported through feast

Describe alternatives you've considered
We have tried to flatten map into new feature view but is wasteful for feature view with lots of map type features
</issue_description>

<agent_instructions>Based on #5772 we need to update the docs on the type system supported docs/reference/type-system.md

probably would make sense to make a table with the supported types and a single feature view with all of the listed types as an example that can be copy pasted.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@franciscojavierarceo @nquinn408 I see you have a fork with some of these already supported? I think we technically already support dictionary types but maybe it's not documented or maybe under only some conditions?

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@franciscojavierarceo
docs: Add comprehensive type system documentation with Map support
a3c0135 
- Add detailed tables for all supported types (primitive, array, map)
- Include complete feature view example with all types
- Add Map type usage examples with nested structures
- Improve documentation structure and clarity

Co-authored-by: franciscojavierarceo <[email protected]>
Copilot AI changed the title [WIP] Add support for map value data type in feature store docs: Add comprehensive type system reference with Map type support Jan 14, 2026
@franciscojavierarceo franciscojavierarceo marked this pull request as ready for review January 14, 2026 14:36
@franciscojavierarceo franciscojavierarceo requested a review from a team as a code owner January 14, 2026 14:36
@franciscojavierarceo franciscojavierarceo merged commit 07b493f into master Jan 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@franciscojavierarceo franciscojavierarceo

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Support for Map value data type

2 participants

@franciscojavierarceo