Skip to content

Upgrade cookie to 0.6.0#105

Closed
6km wants to merge 3 commits intoexpressjs:masterfrom
6km:master
Closed

Upgrade cookie to 0.6.0#105
6km wants to merge 3 commits intoexpressjs:masterfrom
6km:master

Conversation

@6km
Copy link

@6km 6km commented May 10, 2024 •
edited by UlisesGascon
Loading

Update cookie to support partitioned option.

close #102.

@6km
Copy link
Author

6km commented May 12, 2024 •
edited
Loading

@UlisesGascon I believe there's an issue with node 8 and 9 tests.

@6km
Copy link
Author

6km commented May 15, 2024

@UlisesGascon Can you re-run the github action please? I believe it has been fixed by #104.

UlisesGascon
UlisesGascon reviewed May 15, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this @6km!

The CI issues are related to #104, so it can be ignored (with a rebase can be solved).

Seems like this PR should add the changes in the HISTORYmd too, see.

I think that we can release currently what is unrelased and the then merge this PR, so the end users can migrate in smaller steps if they want.

@UlisesGascon UlisesGascon mentioned this pull request May 15, 2024
Closed
1 task
@UlisesGascon UlisesGascon changed the title Update cookie to 0.6.0 Upgrade cookie to 0.6.0 May 15, 2024
@kumarrishav
Copy link

kumarrishav commented Jun 25, 2024

QQ:

I understand we should be updating the module anyway, but from technical perspective, is this cookie to 0.6.0 upgrade required for partitioned purpose?
because cookie-parser is only for http cookie in the request. But partitioned attribute plays role in the response cookie.

@jamesread
Copy link

jamesread commented Oct 6, 2024

This should be bumped to 0.7.0, as 0.6.0 is affected by this; GHSA-pxg6-pf52-xh8x

@jamesread jamesread mentioned this pull request Oct 6, 2024
Closed
@xfournet
Copy link

xfournet commented Oct 7, 2024

The dependency version should not be pinned to allow automatic upgrade

@UlisesGascon
Copy link
Member

UlisesGascon commented Oct 8, 2024

surpassed #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon left review comments

Assignees

No one assigned

Labels

deps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update cookie parser to allow the new attribute partitioned

5 participants

@6km @kumarrishav @jamesread @xfournet @UlisesGascon