Detect set operations over uncorrelated subqueries in Cosmos #37603
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Addresses #37583 by detecting Cosmos set operations over root (uncorrelated) entity queries early, so EF Core fails translation with the expected InvalidOperationException details instead of letting an invalid query reach Cosmos and throwing a CosmosException.
Changes:
- Added a guard in Cosmos set operation translation (e.g.
Concat) to detect root entity queries and surfaceCosmosStrings.NonCorrelatedSubqueriesNotSupported. - Fixed
SourceExpression.Updateto preserve theWithInflag when cloning/rewriting sources. - Added a Cosmos functional test asserting
Concatover two entity query roots fails translation with details.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/EFCore.Cosmos.FunctionalTests/Query/NorthwindMiscellaneousQueryCosmosTest.cs | Adds coverage for Concat over entity roots throwing translation failure with the expected Cosmos-specific details. |
| src/EFCore.Cosmos/Query/Internal/Expressions/SourceExpression.cs | Ensures WithIn is preserved when updating a SourceExpression, supporting correct query-shape detection. |
| src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs | Detects and rejects set operations over root queries to avoid generating invalid uncorrelated subqueries for Cosmos. |
src/EFCore.Cosmos/Query/Internal/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37583