Skip to content

Fixing flaky test ListContainersCmdIT.testStatusFilter #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddumelendez merged 3 commits into from
Oct 26, 2023
Merged

Fixing flaky test ListContainersCmdIT.testStatusFilter #2188

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6227e4
Fixing flaky test `ListContainersCmdIT.testStatusFilter`
dmmax Aug 21, 2023
1e0886b
Add wait for a container after stop
dmmax Aug 23, 2023
881fa42
Merge branch 'main' into fix_flaky_test_list_containers_cmd
eddumelendez Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 40 additions & 22 deletions docker-java/src/test/java/com/github/dockerjava/cmd/ListContainersCmdIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import java.util.List;
import java.util.Map;
import java.util.UUID;
import java.util.concurrent.TimeUnit;

import static ch.lambdaj.Lambda.filter;
import static com.github.dockerjava.api.model.HostConfig.newHostConfig;
Expand Down Expand Up @@ -188,16 +189,8 @@ public void testIdsFilter() {
}

@Test
public void testStatusFilter() {
String id1, id2;
id1 = dockerRule.getClient().createContainerCmd(DEFAULT_IMAGE)
.withCmd("sh", "-c", "sleep 99999")
.withLabels(testLabel)
.exec()
.getId();

id2 = dockerRule.getClient().createContainerCmd(DEFAULT_IMAGE)
.withCmd("sh", "-c", "sleep 99999")
public void shouldFilterByCreatedStatus() {
String containerId = dockerRule.getClient().createContainerCmd(DEFAULT_IMAGE)
.withLabels(testLabel)
.exec()
.getId();
Expand All @@ -208,42 +201,67 @@ public void testStatusFilter() {
.withStatusFilter(singletonList("created"))
.exec();

assertThat(filteredContainers.size(), is(2));
assertThat(filteredContainers.get(1).getId(), isOneOf(id1, id2));
assertThat(filteredContainers.size(), is(1));
assertThat(filteredContainers.get(0).getId(), is(containerId));
}

dockerRule.getClient().startContainerCmd(id1).exec();
@Test
public void shouldFilterByRunningStatus() {
String containerId = dockerRule.getClient().createContainerCmd(DEFAULT_IMAGE)
.withLabels(testLabel)
.exec()
.getId();
dockerRule.getClient().startContainerCmd(containerId).exec();

filteredContainers = dockerRule.getClient().listContainersCmd()
List<Container> filteredContainers = dockerRule.getClient().listContainersCmd()
.withShowAll(true)
.withLabelFilter(testLabel)
.withStatusFilter(singletonList("running"))
.exec();

assertThat(filteredContainers.size(), is(1));
assertThat(filteredContainers.get(0).getId(), is(id1));
assertThat(filteredContainers.get(0).getId(), is(containerId));
}

dockerRule.getClient().pauseContainerCmd(id1).exec();
@Test
public void shouldFilterByPausedStatus() {
String containerId = dockerRule.getClient().createContainerCmd(DEFAULT_IMAGE)
.withCmd("sh", "-c", "sleep 99999")
.withLabels(testLabel)
.exec()
.getId();
dockerRule.getClient().startContainerCmd(containerId).exec();
dockerRule.getClient().pauseContainerCmd(containerId).exec();

filteredContainers = dockerRule.getClient().listContainersCmd()
List<Container> filteredContainers = dockerRule.getClient().listContainersCmd()
.withShowAll(true)
.withLabelFilter(testLabel)
.withStatusFilter(singletonList("paused"))
.exec();

assertThat(filteredContainers.size(), is(1));
assertThat(filteredContainers.get(0).getId(), is(id1));
assertThat(filteredContainers.get(0).getId(), is(containerId));
}

dockerRule.getClient().unpauseContainerCmd(id1).exec();
dockerRule.getClient().stopContainerCmd(id1).exec();
@Test
public void shouldFilterByExitedStatus() throws InterruptedException {
String containerId = dockerRule.getClient().createContainerCmd(DEFAULT_IMAGE)
.withCmd("sh", "-c", "sleep 99999")
.withLabels(testLabel)
.exec()
.getId();
dockerRule.getClient().startContainerCmd(containerId).exec();
dockerRule.getClient().stopContainerCmd(containerId).exec();
dockerRule.getClient().waitContainerCmd(containerId).start().awaitCompletion(15, TimeUnit.SECONDS);

filteredContainers = dockerRule.getClient().listContainersCmd()
List<Container> filteredContainers = dockerRule.getClient().listContainersCmd()
.withShowAll(true)
.withLabelFilter(testLabel)
.withStatusFilter(singletonList("exited"))
.exec();

assertThat(filteredContainers.size(), is(1));
assertThat(filteredContainers.get(0).getId(), is(id1));
assertThat(filteredContainers.get(0).getId(), is(containerId));
}

@Test
Expand Down