Skip to content

Fix #1258: Support copyUIDGID option in CopyArchiveToContainerCmd #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eddumelendez merged 3 commits into from
Oct 17, 2022
Merged

Fix #1258: Support copyUIDGID option in CopyArchiveToContainerCmd #1963

eddumelendez merged 3 commits into from
Oct 17, 2022

Conversation

@k-wall
Copy link
Contributor

@k-wall k-wall commented Sep 27, 2022 •
edited
Loading

The changes maintain the existing semantics (i.e. copyUIDGID = false) unless the caller sets the new option true.
Supporting integration test added.

Signed-off-by: kwall [email protected]

@k-wall
Copy link
Contributor Author

k-wall commented Sep 28, 2022

I'm a Podman user rather than Docker. I'm hoping my changes will allow the new IT to pass against Docker too. Thank you.

@k-wall
Copy link
Contributor Author

k-wall commented Oct 5, 2022

would a reviewer be able to take a look at this PR please?

@eddumelendez eddumelendez merged commit d7db365 into docker-java:master Oct 17, 2022
@eddumelendez
Copy link
Member

eddumelendez commented Oct 17, 2022

thanks for your contribution @k-wall! This is now part of master branch

@eddumelendez eddumelendez added this to the next milestone Oct 17, 2022
@k-wall k-wall deleted the issue-1258 branch October 17, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddumelendez eddumelendez eddumelendez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2.14

Development

Successfully merging this pull request may close these issues.

2 participants

@k-wall @eddumelendez