Skip to content

DEV: Migrate nav menu preferences to use formkit #36704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jordanvidrine wants to merge 5 commits into
base: main
Choose a base branch
from
Open

DEV: Migrate nav menu preferences to use formkit #36704

jordanvidrine wants to merge 5 commits into from
+183 −128

Conversation

@jordanvidrine
Copy link
Contributor

@jordanvidrine jordanvidrine commented Dec 15, 2025

Fairly straightforward refactor.

Before After
CleanShot 2025-12-15 at 15 20 04@2x CleanShot 2025-12-15 at 15 19 40@2x

@jordanvidrine jordanvidrine marked this pull request as ready for review December 15, 2025 21:20
martin-brennan
martin-brennan reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

@martin-brennan martin-brennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change so far, but we do need a system spec here. Also you have some failing tests

frontend/discourse/app/templates/preferences/navigation-menu.gjs
</template>
this.args.model
.save(this.saveAttrNames)
.catch(popupAjaxError)
Copy link
Contributor

@martin-brennan martin-brennan Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will need to handle rolling back the model values on error here

Copy link
Contributor Author

@jordanvidrine jordanvidrine Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .save() is what actually changes these items. I looked at the way other controllers for these preferences were doing it.

discourse/frontend/discourse/app/controllers/preferences/users.js

Lines 76 to 84 in ee1a1c7

@action
save() {
this.set("saved", false);
return this.model
.save(this.saveAttrNames)
.then(() => this.set("saved", true))
.catch(popupAjaxError);
}

discourse/frontend/discourse/app/controllers/preferences/interface.js

Lines 381 to 469 in ee1a1c7

@action
save() {
this.set("saved", false);
const makeThemeDefault = this.makeThemeDefault;
if (makeThemeDefault) {
this.set("model.user_option.theme_ids", [this.themeId]);
}
const makeTextSizeDefault = this.makeTextSizeDefault;
if (makeTextSizeDefault) {
this.set("model.user_option.text_size", this.textSize);
}
if (!this.showColorSchemeSelector) {
this.set("model.user_option.color_scheme_id", null);
this.set("model.user_option.dark_scheme_id", null);
} else if (this.makeColorSchemeDefault) {
this.set("model.user_option.color_scheme_id", this.selectedColorSchemeId);
this.set(
"model.user_option.dark_scheme_id",
this.selectedDarkColorSchemeId
);
if (this.selectedInterfaceColorModeId) {
this.set(
"model.user_option.interface_color_mode",
this.selectedInterfaceColorModeId
);
}
}
return this.model
.save(this.saveAttrNames)
.then(() => {
this.set("saved", true);
if (makeThemeDefault) {
setLocalTheme([]);
} else {
setLocalTheme(
[this.themeId],
this.get("model.user_option.theme_key_seq")
);
}
if (makeTextSizeDefault) {
this.model.updateTextSizeCookie(null);
} else {
this.model.updateTextSizeCookie(this.textSize);
}
if (this.makeColorSchemeDefault) {
updateColorSchemeCookie(null);
updateColorSchemeCookie(null, { dark: true });
} else {
updateColorSchemeCookie(this.selectedColorSchemeId);
if (
this.defaultDarkSchemeId > 0 &&
this.selectedDarkColorSchemeId === this.defaultDarkSchemeId
) {
updateColorSchemeCookie(null, { dark: true });
} else {
updateColorSchemeCookie(this.selectedDarkColorSchemeId, {
dark: true,
});
}
}
if (this.selectedInterfaceColorModeId) {
if (this.isViewingOwnProfile) {
const modeId = this.selectedInterfaceColorModeId;
if (modeId === INTERFACE_COLOR_MODES.AUTO) {
this.interfaceColor.useAutoMode();
} else if (modeId === INTERFACE_COLOR_MODES.LIGHT) {
this.interfaceColor.forceLightMode();
} else if (modeId === INTERFACE_COLOR_MODES.DARK) {
this.interfaceColor.forceDarkMode();
}
}
this.selectedInterfaceColorModeId = null;
}
this.homeChanged();
if (this.themeId && this.themeId !== this.currentThemeId) {
reload();
}
})
.catch(popupAjaxError);
}

@jordanvidrine
Copy link
Contributor Author

jordanvidrine commented Dec 16, 2025

we do need a system spec here

I have added one, and removed a dated one that no longer seemed to be in use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-brennan martin-brennan martin-brennan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jordanvidrine @martin-brennan