Test the License description component #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akmadian
previously requested changes
Oct 6, 2019
Member
There was a problem hiding this comment.
A few things I've noticed, I assume that this is still a work in progress so please don't feel like I'm judging you harshly right off the bat
- Only
selectedLicenseis a prop. The adapt and description are computed properties, and as I far as I can tell, you can't pass computed properties with propsData. - Please move the spec file into
./test/unit/specs/components/I just switched this up and I'm trying to keep everything organized. - If your PR is still a work in progress, please add "WIP: " to the start of your PR title, and remove it when you're done so I know you're ready for a final review :)
75pollet
changed the title
Author
|
@akmadian thanks for the corrections. Making the changes right away |
…dd test cases and remove computed properties from propsData
akmadian
dismissed
their stale review
Changes made! Please keep in mind that I would still like for the computed props to be tested in some way, though.
…n is provided depending on the license that has been chosen
…8-write-tests-for-license-description-component
…that has been selected
…8-write-tests-for-license-description-component
75pollet
changed the title
akmadian
approved these changes
Oct 16, 2019
Member
|
Thanks, @75pollet! Sorry it took me a while to get to this, merging now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
Description
Other information
Checklist:
Update index.md).masterbranch of the repository.visible errors.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.