-
Notifications
You must be signed in to change notification settings - Fork 2
Add filtering by date range #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
src/models/eventsFactory.js
Outdated
| * @property {boolean} [starred] | ||
| * @property {boolean} [resolved] | ||
| * @property {boolean} [ignored] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant jsdoc removal
| /** | ||
| * Check if pattern is safe RegExp | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected jsdoc removal
src/models/eventsFactory.js
Outdated
| ...searchFilter, | ||
| }; | ||
|
|
||
| // Filter by marks (event.marks.{key}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // Filter by marks (event.marks.{key}) |
src/models/eventsFactory.js
Outdated
| /** | ||
| * aggregation can return empty array so that | ||
| * result can be undefined | ||
| * | ||
| * for that we check result existence | ||
| * | ||
| * extra field `projectId` needs to satisfy GraphQL query | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave jsdoc please
What’s changed
recentEventsfiltering:dateFrom/dateTofilters (viagroupingTimestamp)