fix(site): allow updating workspace in TaskPage #21316
Merged
+79
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
changed the title
johnstcn
changed the title
johnstcn
force-pushed
the
cj/gh20925/task-start-latest-version
branch
from
0b429f9 to
2021127
Compare
Closed
1 task
Comment on lines
410
to
420
| spyOn(API, "getTask").mockResolvedValue(MockTask); | ||
| spyOn(API, "getWorkspaceByOwnerAndName").mockResolvedValue({ | ||
| ...MockStoppedWorkspace, | ||
| outdated: true, | ||
| }); | ||
| spyOn(API, "getTemplate").mockResolvedValue({ | ||
| ...MockTemplate, | ||
| active_version_id: "some-other-version-id", | ||
| }); | ||
| spyOn(API, "getTemplateVersionRichParameters").mockResolvedValue([]); | ||
| spyOn(API, "getWorkspaceBuildParameters").mockResolvedValue([]); |
Contributor
There was a problem hiding this comment.
These should be replaced with the parameters: { queries: { flow. See LongDisplayName for reference
Member
Author
There was a problem hiding this comment.
Done. This has the slightly annoying side-effect of queries happening after 5 seconds though.
Contributor
There was a problem hiding this comment.
Yeah, I think we need to schedule some time with the front end folk to address that
DanielleMaywood
approved these changes
Dec 18, 2025
aslilac
reviewed
Dec 18, 2025
site/src/modules/workspaces/WorkspaceOutdatedTooltip/WorkspaceOutdatedTooltip.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #20925
This PR modifies TaskPage to update an outdated workspace instead of starting it. Before, starting an outdated workspace where the template required the active version would fail with the error "cannot use non-active version: rbac: forbidden".
For the case of a dormant workspace, I deemed it safe enough to simply unset dormancy on an attempted start (ref: #21306). However, automatically updating a workspace is a more risky option, so I instead elected to give the user the option of updating their workspace using the existing tooltip.
Note: I made a change to the
WorkspaceOutdatedTooltipcomponents to allow it to have children so that the tooltip could trigger over a wider element instead of just the info icon.