fix: report correct request paths from workspace proxy metrics #21302
+38
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibetitsmike
reviewed
Dec 17, 2025
| return "" | ||
| } | ||
|
|
||
| if pattern := rctx.RoutePattern(); pattern != "" { |
Contributor
There was a problem hiding this comment.
IIRC the idea I had was to avoid double resolution as much as possible, if you are confident that's not going to be the problem - the rest looks good
Contributor
Author
There was a problem hiding this comment.
It would be nice to avoid, but since we need to get the path in normalized form before we actually handle the request, we need to resolve it here.
ibetitsmike
approved these changes
Dec 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while looking at scale test metrics that we don't always report a useful path in the API request metrics.
There are a lot of requests with path
/*. I chased this problem to the workspace proxy, where we mount a the proxy router as a child of a "root" router to support some high level endpoints likelatency-check.Because we query the path from the Chi route context in the prometheus middleware before the request is actually handled, we can have a partially resolved pattern match only corresponding to the root router. The fix is to always re-resolve the path, rather than accept a partially resolved path.