fix: resolve shell script syntax errors in docs workflow

EdwardAngert · claude · EdwardAngert · commit aacac5c4b44a · 2025-04-24T13:02:59.000-04:00
- Fix duplicate cross-reference validation code block - Fix improper if-else nesting in comment formatting - Repair syntax error near 'else' token 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/.github/docs/actions/docs-core/action.yaml b/.github/docs/actions/docs-core/action.yaml
@@ -894,143 +894,6 @@ runs:
         BROKEN_IMAGES=0
         TOTAL_REFS=0
         
-        # 1. Check for references to deleted files
-        if [ "$DELETED_FILES_JSON" \!= "[]" ] && [ -n "$DELETED_FILES_JSON" ]; then
-          echo "Checking for references to deleted files..."
-          
-          # Extract deleted file list without extensions for matching
-          DELETED_FILES=$(echo "$DELETED_FILES_JSON" | jq -r '.[] | select(endswith(".md"))' | sed 's/\.md$//' | sort)
-          
-          if [ -n "$DELETED_FILES" ]; then
-            # For each deleted file, check if any existing files reference it
-            echo "$DELETED_FILES" | while read -r deleted_file; do
-              # Skip empty lines
-              [ -z "$deleted_file" ] && continue
-              
-              # Extract filename portion for matching
-              deleted_name=$(basename "$deleted_file")
-              
-              # Use grep to find references to this file across all docs
-              echo "Checking references to: $deleted_name"
-              REFS_TO_DELETED=$(grep -l -r --include="*.md" "\[$deleted_name\]" "$DOCS_DIR" 2>/dev/null || echo "")
-              
-              if [ -n "$REFS_TO_DELETED" ]; then
-                echo "::warning::Found references to deleted file '$deleted_name' in these files:"
-                echo "$REFS_TO_DELETED" | sed 's/^/  - /'
-                BROKEN_REFS=$((BROKEN_REFS + 1))
-              fi
-            done
-          fi
-        fi
-        
-        # 2. Check for broken internal links in changed files
-        if [ "$CHANGED_FILES_JSON" \!= "[]" ] && [ -n "$CHANGED_FILES_JSON" ]; then
-          echo "Checking for broken internal links in changed files..."
-          
-          echo "$CHANGED_FILES_JSON" | jq -r '.[]' | grep '\.md$' | while read -r file; do
-            # Skip empty lines
-            [ -z "$file" ] && continue
-            
-            # Extract all internal links with the [text](link) pattern
-            LINKS=$(grep -o -E '\[.+?\]\(\s*[^(http|https|mailto|#)][^)]+\s*\)' "$file" 2>/dev/null || echo "")
-            
-            if [ -n "$LINKS" ]; then
-              # For each link, check if the target exists
-              echo "$LINKS" | while read -r link_match; do
-                # Extract just the URL part from [text](url)
-                link_url=$(echo "$link_match" | sed -E 's/\[.+?\]\(\s*([^)]+)\s*\)/\1/')
-                
-                # Count total refs
-                TOTAL_REFS=$((TOTAL_REFS + 1))
-                
-                # Handle relative links correctly
-                if [[ "$link_url" == /* ]]; then
-                  # Absolute path from repo root
-                  link_path="$link_url"
-                else
-                  # Relative path, get directory of current file
-                  file_dir=$(dirname "$file")
-                  link_path="$file_dir/$link_url"
-                fi
-                
-                # Remove any anchor fragment
-                link_path=$(echo "$link_path" | sed 's/#.*//')
-                
-                # Normalize path (add .md if missing)
-                if [[ \! "$link_path" =~ \.[a-zA-Z0-9]+$ ]]; then
-                  link_path="${link_path}.md"
-                fi
-                
-                # Clean up the path (remove double slashes, etc.)
-                link_path=$(echo "$link_path" | sed 's@//@/@g' | sed 's@\./@/@g')
-                
-                # Check if the link target exists
-                if [ \! -f "$link_path" ]; then
-                  echo "::warning::Broken link in $file: $link_match -> $link_path (file not found)"
-                  BROKEN_REFS=$((BROKEN_REFS + 1))
-                fi
-              done
-            fi
-          done
-        fi
-        
-        # 3. Check for broken image references
-        if [ "$CHANGED_FILES_JSON" \!= "[]" ] && [ -n "$CHANGED_FILES_JSON" ]; then
-          echo "Checking for broken image references..."
-          
-          echo "$CHANGED_FILES_JSON" | jq -r '.[]' | grep '\.md$' | while read -r file; do
-            # Skip empty lines
-            [ -z "$file" ] && continue
-            
-            # Extract all image references with the \![text](link) pattern
-            IMAGES=$(grep -o -E '\!\[.+?\]\(\s*[^(http|https)][^)]+\s*\)' "$file" 2>/dev/null || echo "")
-            
-            if [ -n "$IMAGES" ]; then
-              # For each image, check if it exists
-              echo "$IMAGES" | while read -r img_match; do
-                # Extract just the URL part from \![text](url)
-                img_url=$(echo "$img_match" | sed -E 's/\!\[.+?\]\(\s*([^)]+)\s*\)/\1/')
-                
-                # Handle relative paths correctly
-                if [[ "$img_url" == /* ]]; then
-                  # Absolute path from repo root
-                  img_path="$img_url"
-                else
-                  # Relative path, get directory of current file
-                  file_dir=$(dirname "$file")
-                  img_path="$file_dir/$img_url"
-                fi
-                
-                # Clean up the path
-                img_path=$(echo "$img_path" | sed 's@//@/@g' | sed 's@\./@/@g')
-                
-                # Check if the image exists
-                if [ \! -f "$img_path" ]; then
-                  echo "::warning::Broken image in $file: $img_match -> $img_path (file not found)"
-                  BROKEN_IMAGES=$((BROKEN_IMAGES + 1))
-                fi
-              done
-            fi
-          done
-        fi
-        
-        # Determine status based on findings
-        if [ $BROKEN_REFS -eq 0 ] && [ $BROKEN_IMAGES -eq 0 ]; then
-          echo "No broken cross-references found\!"
-          echo "status=success" >> $GITHUB_OUTPUT
-          echo "message=No broken cross-references found ($TOTAL_REFS refs checked)" >> $GITHUB_OUTPUT
-        else
-          # Make this a warning, not an error, to still allow preview generation
-          echo "status=warning" >> $GITHUB_OUTPUT
-          echo "message=Found $BROKEN_REFS broken links and $BROKEN_IMAGES broken images" >> $GITHUB_OUTPUT
-          echo "broken_refs=$BROKEN_REFS" >> $GITHUB_OUTPUT
-          echo "broken_images=$BROKEN_IMAGES" >> $GITHUB_OUTPUT
-        fi
-        # Initialize results tracking
-        BROKEN_REFS=0
-        BROKEN_IMAGES=0
-        TOTAL_REFS=0
-        
         # Set default value for DELETED_FILES_JSON if not provided
         if [ -z "$DELETED_FILES_JSON" ]; then
           DELETED_FILES_JSON="[]"
@@ -1452,6 +1315,29 @@ runs:
           if [ -n "$RESULTS_ARRAY" ]; then
             has_issues="true"
             GH_COMMENT+="The detailed validation status is available in the \"Documentation Validation\" check in this PR. Common issues and solutions:\n\n"
+            
+            # Add specific issues
+            GH_COMMENT+="### Detected Issues\n\n"
+            
+            echo "$RESULTS_ARRAY" | while read -r result; do
+              name=$(echo "$result" | jq -r '.name')
+              guidance=$(echo "$result" | jq -r '.guidance')
+              fix_command=$(echo "$result" | jq -r '.fix_command')
+              
+              GH_COMMENT+="#### $name\n\n"
+              GH_COMMENT+="$guidance\n\n"
+              
+              if [ -n "$fix_command" ] && [ "$fix_command" != "null" ]; then
+                GH_COMMENT+="```bash\n$fix_command\n```\n\n"
+              fi
+            done
+          else
+            # Even when there are no issues, provide helpful guidance
+            GH_COMMENT+="All validation checks passed! &#9989;\n\n"
+            GH_COMMENT+="The detailed validation status is available in the \"Documentation Validation\" check in this PR. Common tasks:\n\n"
+            GH_COMMENT+="- **Check links**: Run \`pnpm run docs:check-links\` locally\n"
+            GH_COMMENT+="- **Format documents**: Run \`pnpm run docs:fix\` locally\n"
+            GH_COMMENT+="- **Preview changes**: Use the preview links above\n"
           fi
         else
           # Default to showing help for error cases
@@ -1462,29 +1348,6 @@ runs:
           GH_COMMENT+="- **Link issues**: Run \`pnpm run docs:check-links\` locally\n"
           GH_COMMENT+="- **Style issues**: Run \`pnpm run docs:fix\` locally\n"
           GH_COMMENT+="- **Cross-reference issues**: Check heading IDs and link references\n\n"
-          
-          # Add specific issues
-          GH_COMMENT+="### Detected Issues\n\n"
-          
-          echo "$RESULTS_ARRAY" | while read -r result; do
-            name=$(echo "$result" | jq -r '.name')
-            guidance=$(echo "$result" | jq -r '.guidance')
-            fix_command=$(echo "$result" | jq -r '.fix_command')
-            
-            GH_COMMENT+="#### $name\n\n"
-            GH_COMMENT+="$guidance\n\n"
-            
-            if [ -n "$fix_command" ] && [ "$fix_command" != "null" ]; then
-              GH_COMMENT+="```bash\n$fix_command\n```\n\n"
-            fi
-          done
-        else
-          # Even when there are no issues, provide helpful guidance
-          GH_COMMENT+="All validation checks passed! &#9989;\n\n"
-          GH_COMMENT+="The detailed validation status is available in the \"Documentation Validation\" check in this PR. Common tasks:\n\n"
-          GH_COMMENT+="- **Check links**: Run \`pnpm run docs:check-links\` locally\n"
-          GH_COMMENT+="- **Format documents**: Run \`pnpm run docs:fix\` locally\n"
-          GH_COMMENT+="- **Preview changes**: Use the preview links above\n"
         fi
         
         GH_COMMENT+="</details>\n\n"
