sql/opt: allow plans with routines to be cached #162057
Open
+1,482
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't catch cockroachdb#162055 in our opt tests because they go through the test catalog, while cockroachdb#162055 requires a real catalog to reproduce. This commit adds an execbuilder test to show the query plan caching behavior for different types of prepared statements, including some that contain a reference to a routine. Informs cockroachdb#162055 Release note: None
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
DrewKimball
changed the title
Collaborator
Author
|
This was originally just going to add tests, but the fix ended up being pretty simple, so included that too. |
This commit slightly modifies the metadata staleness check so that: * The version is not checked when resolving a routine by name. This is necessary because overloads looked up by name are not fully hydrated and do not have the version set. * All routines are checked against the overload resolved by OID regardless of whether the reference in the query was by name. This lets us do the version check with the correct version. As a result of these changes, the staleness check now correctly identifies when a routine descriptor has not changed since a query plan was cached. Fixes cockroachdb#162055 Release note (performance improvement): Fixed a performance bug that prevented query plans containing user-defined functions from being cached. Repeated executions of prepared statements containing UDFs will now have less planning overhead.
DrewKimball
force-pushed
the
prepare-cache
branch
from
67065bc to
eb1ea9a
Compare
michae2
approved these changes
Jan 30, 2026
Collaborator
michae2
left a comment
michae2
left a comment
There was a problem hiding this comment.
Is it intentional that we're adding all these logictest configs to the exec logictest?
@michae2 reviewed 24 files and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql/opt: add execbuilder test for query caching behavior
We didn't catch #162055 in our opt tests because they go through the
test catalog, while #162055 requires a real catalog to reproduce. This
commit adds an execbuilder test to show the query plan caching behavior
for different types of prepared statements, including some that contain
a reference to a routine.
Informs #162055
Release note: None
sql/opt: allow plans with routines to be cached
This commit slightly modifies the metadata staleness check so that:
necessary because overloads looked up by name are not fully hydrated
and do not have the version set.
of whether the reference in the query was by name. This lets us do the
version check with the correct version.
As a result of these changes, the staleness check now correctly identifies
when a routine descriptor has not changed since a query plan was cached.
Fixes #162055
Release note (performance improvement): Fixed a performance bug that
prevented query plans containing user-defined functions from being
cached. Repeated executions of prepared statements containing UDFs
will now have less planning overhead.