Skip to content

Conversation

@netsafe
Copy link

@netsafe netsafe commented Feb 14, 2025

The NginX process writes it's version output to stderr, but if it's wrapped in a script - like interacting with the Docker container like this:

# cat /usr/sbin/nginx
#!/bin/bash

/usr/bin/docker exec -it nginx $0 $@

then all the stuff goes to stdout, and a locally installed certbot is issuing an error

 The error was: PluginError('Unable to find Nginx version')

so this tiny patch fixes things up and expands the integration ability of Certbot out of the box

When the nginx output is wrapped - it can be in stdout, when it's native - it's in stderr. This tiny enhancement enables better certbot integration for cases like having NginX in a Docker container
As it was proposed in a pull request template - why not? ;)
@zoracon zoracon requested a review from bmw February 20, 2025 22:43
@netsafe
Copy link
Author

netsafe commented Jun 18, 2025

any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants