dns-rfc2136: allow hostname for dns_rfc2136_server option #10072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxxcoder
force-pushed
the
main
branch
4 times, most recently
from
a4f652f to
7aa1e55
Compare
Author
|
Sphinx build fails but to me it seems to be caused by the build system and not my code changes. |
cxxcoder
force-pushed
the
main
branch
3 times, most recently
from
a87cfd6 to
3864504
Compare
support dns_rfc2136_ip_family config parameter with ipv4 or ipv6 to limit DNS lookup to IPv4 or IPv6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying a hostname instead of an IP adress by the
dns_rfc2136_serveroption in the credentials .ini file.The current state that only IP addresses are supported is not satisfactory because there might be DNS providers whose servers periodically change their IP address or might have different IPs due to load balancing.
There is also an open issue for that (#6282) and a very old PR (#5664) but this PR used socket.gethostbyname() which does not support IPv6.
Pull Request Checklist
mainsection ofcertbot/CHANGELOG.mdto include a description of the change being made.AUTHORS.mdif you like.