Skip to content

Conversation

@moein
Copy link

@moein moein commented Nov 20, 2020

Describe the PR

isUndefined is being used incorrectly in these files and causes errors when used.
For example in form-text.js result is assigned null and then checked with isUndefined which returns false for null.
So when hasFormatter is called it returns true !isUndefined(null) and later this.formatter() is called which causes the error: null is not a function

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc.). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercel bot commented Nov 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/1zat05cv7
✅ Preview: https://bootstrap-vue-git-dev.bootstrap-vue.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4141038:

Sandbox Source
BootstrapVue Starter Project Configuration

@jacobmllr95
Copy link
Member

@moein I've created a new PR that improves the user-supplied prop function detection overall.

Can you please check this CodeSandbox to confirm that your issues is resolved with the changes in the PR:
https://codesandbox.io/s/bootstrapvue-starter-project-qd9ob

@moein
Copy link
Author

moein commented Nov 25, 2020

Hi @jackmu95
Sorry for the late answer.
I'm using the library in a vue theme that I bought and that's how I stumbled upon the bug so I have no idea how to test the exact scenario. But looking at your PR it makes complete sense and should fix the issue.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants