New option to control the stream id generation#40
Open
erlichmen wants to merge 1 commit intobinaryjs:masterfrom
Open
New option to control the stream id generation#40erlichmen wants to merge 1 commit intobinaryjs:masterfrom
erlichmen wants to merge 1 commit intobinaryjs:masterfrom
Conversation
New server option to control the generation of the stream id, the default behaviour is incrementing numbers (odds for server side stream, even for client side stream) but for all kinds of proposes you might want to control how those ids are generated.
|
On my side, I created a custom ID, server side because when 2 clients connects they always get the same ID which leads to errors. Stream ID should be returned by the server when connection is opened. |
Author
|
@arnaudbreton interesting can you post the changes? |
|
It's not integrated in BinaryJS at the moment, fully handled in my code. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New server option to control the generation of the stream id, the default behaviour is incrementing numbers (odds for server side stream, even for client side stream) but for all kinds of proposes you might want to control how those ids are generated.