[IcebergIO] Create tables with Iceberg Table Properties#35496
Merged
ahmedabu98 merged 5 commits intoapache:masterfrom Jul 2, 2025
Merged
[IcebergIO] Create tables with Iceberg Table Properties#35496ahmedabu98 merged 5 commits intoapache:masterfrom
ahmedabu98 merged 5 commits intoapache:masterfrom
Conversation
tarun-google
force-pushed
the
iceberg_table_properties
branch
from
45ed005 to
c561272
Compare
tarun-google
force-pushed
the
iceberg_table_properties
branch
from
c561272 to
a7b77ad
Compare
tarun-google
changed the title
ahmedabu98
reviewed
Jul 1, 2025
Contributor
ahmedabu98
left a comment
ahmedabu98
left a comment
There was a problem hiding this comment.
Thanks @tarun-google, this looks great! just one comment
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergCatalogConfig.java
Outdated
Show resolved
Hide resolved
Contributor
|
Also no need to manually update the docs, just run |
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
tarun-google
force-pushed
the
iceberg_table_properties
branch
from
0efb25b to
5458a46
Compare
Contributor
Author
|
"Run Java PreCommit" |
Contributor
Author
|
Run Java PreCommit |
Contributor
|
Congrats on your first PR @tarun-google! |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Fixes issue #34966
Allows users to pass Iceberg Table properties which are used while creating a table. For more information on table properties please visit https://iceberg.apache.org/docs/latest/configuration/#table-properties
This PR only addresses providing table-properties through beam-sdks-java-io-iceberg. It does not handle providing properties through Beam SQL