Exactly one of Topic or Subscription must be set in pubsubio.go#35369
Merged
lostluck merged 6 commits intoapache:masterfrom Jul 5, 2025
Merged
Exactly one of Topic or Subscription must be set in pubsubio.go#35369lostluck merged 6 commits intoapache:masterfrom
lostluck merged 6 commits intoapache:masterfrom
Conversation
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
Author
|
Run Go PreCommit |
Contributor
Author
|
R: @lostluck |
Contributor
|
Assigning reviewers: R: @shunping for label go. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
lostluck
requested changes
Jun 23, 2025
Contributor
lostluck
left a comment
lostluck
left a comment
There was a problem hiding this comment.
Please add an entry in CHANGES.md about the breaking change as well.
Contributor
|
waiting on author |
Contributor
Author
|
@lostluck I have addressed the comments. |
lostluck
approved these changes
Jul 5, 2025
Contributor
lostluck
left a comment
lostluck
left a comment
There was a problem hiding this comment.
Just the one typo, and then I'll merge it in. Thank you kindly!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It resolves #35295
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.