Create a varint32 coder and used it for RowCoder#34354
Conversation
|
Python3.9 test passed but 3.2 test failed, due to Likely a race condition that two rename run at the same time when tests run in parallel: |
|
R: @liferoad |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
R: @kennknowles also |
| Coder.register_structured_urn(common_urns.coders.VARINT.urn, VarIntCoder) | ||
|
|
||
|
|
||
| class VarInt32Coder(FastCoder): |
There was a problem hiding this comment.
can we add this to CHANGES.md?
There was a problem hiding this comment.
Thanks, will do as a follow up (otherwise need to rebase this PR onto latest master to be able to add to 2.65.0 section)
|
This appears to break test_avro_schema_to_beam_schema_with_nullable_atomic_fields (apache_beam.io.avroio_test.TestFastAvro) E File "apache_beam/coders/coder_impl.py", line 983, in apache_beam.coders.coder_impl.VarInt32CoderImpl.encode_to_stream |
Also breaks these XVR jobs: #31418, #30601, #30602, #30593, #30517 |
|
Yeah they all fails on same test. Let me investigate now. From first glance it fails on encoding, which means the row passing in already have large integers |
|
hmmm test passed locally: apache_beam/io/avroio_test.py::TestFastAvro::test_avro_schema_to_beam_schema_with_nullable_atomic_fields PASSED [100%] ================================================================================ 1 passed in 13.05s ================================================================================ |
|
It turns out that the test already had an integar overflow in Row passed in: print out the pcollection pass going to pass to SqlTransform: this happens to both before and after this change (#34354) more suprisingly, when read back, it converts back to -1: |
* Create a varint32 coder and used it for RowCoder * Fix checks * Handle a race when multiple process downloading jar at the same time
Fix #34089
This fixes negative int32 field passed from java to python in xlang transform
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.