Add support for collections.abc.Sequence#33999
Merged
jrmccluskey merged 1 commit intoapache:masterfrom Feb 25, 2025
Merged
Conversation
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
msuozzo
force-pushed
the
push-qrurxlztoxyx
branch
from
a6b0bc8 to
be51d23
Compare
Work towards apache#29135 Notes: - The naming used for the TypeConstraint is necessary to avoid colliding with the existing base class used for other collections.abc generics. - The change in transforms/stats.py is required due to a test failure that appears to require `int` be a valid param instead of `Sequence[int]`.
msuozzo
force-pushed
the
push-qrurxlztoxyx
branch
from
be51d23 to
62b5214
Compare
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
|
Reminder, please take a look at this pr: @jrmccluskey |
jrmccluskey
approved these changes
Feb 25, 2025
|
|
||
| @typehints.with_input_types( | ||
| typehints.Union[typing.Sequence[T], Tuple[T, float]]) | ||
| typing.Union[T, typing.Sequence[T], Tuple[T, float]]) |
Contributor
There was a problem hiding this comment.
this is a good catch, not sure why the typehints type was passed through here
jrmccluskey
added a commit
that referenced
this pull request
Feb 27, 2025
This reverts commit 6b8e860.
This was referenced Mar 4, 2025
VardhanThigle
pushed a commit
to VardhanThigle/beam
that referenced
this pull request
Mar 21, 2025
Work towards apache#29135 Notes: - The naming used for the TypeConstraint is necessary to avoid colliding with the existing base class used for other collections.abc generics. - The change in transforms/stats.py is required due to a test failure that appears to require `int` be a valid param instead of `Sequence[int]`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #29135
Notes:
the existing base class used for other collections.abc generics.
appears to require
intbe a valid param instead ofSequence[int].