[Dataflow Streaming] Enable Windmill GetWork Response Batching by default#33847
Merged
scwhittle merged 2 commits intoapache:masterfrom Feb 4, 2025
Merged
[Dataflow Streaming] Enable Windmill GetWork Response Batching by default#33847scwhittle merged 2 commits intoapache:masterfrom
scwhittle merged 2 commits intoapache:masterfrom
Conversation
…ault With this change user workers will request batched responses from backend and backend will send multiple WorkItems in the same response proto. Backend changes are rollbacksafe. The feature can be disabled by passing `--windmillRequestBatchedGetWorkResponse=false`
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
Author
|
Run Java PreCommit |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
|
R: @scwhittle |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
VardhanThigle
pushed a commit
to VardhanThigle/beam
that referenced
this pull request
Mar 21, 2025
…ault (apache#33847) With this change user workers will request batched responses from backend and backend will send multiple WorkItems in the same response proto. Backend changes are rollbacksafe. The feature can be disabled by passing `--windmillRequestBatchedGetWorkResponse=false`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change user workers will request batched responses from backend and backend will send multiple WorkItems in the same response proto. Backend changes are rollbacksafe.
The feature can be disabled by passing
--windmillRequestBatchedGetWorkResponse=false