refactor: drop signal writes effect#455
Merged
Jefiozie merged 1 commit intoangular-split:mainfrom Jan 19, 2025
Merged
Conversation
Member
|
hi @Harpush is this ready for review? |
SanderElias
approved these changes
Nov 21, 2024
Member
|
Hi @Harpush could you resolve the conflict? I would like to add this to the beta release of 19 |
Harpush
force-pushed
the
no-signal-writes-effect
branch
from
8396f22 to
23e36be
Compare
Harpush
force-pushed
the
no-signal-writes-effect
branch
from
23e36be to
afd4840
Compare
Collaborator
Author
|
@Jefiozie @SanderElias Resolved conflicts, changed a bit of the code and now it is ready for review |
Jefiozie
approved these changes
Jan 19, 2025
Member
Jefiozie
left a comment
Jefiozie
left a comment
There was a problem hiding this comment.
LGMT, will update v19 branch with these changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the validation effect that also updates internal sizes (with allow signal writes) and use computed instead as per the official angular recommendation.
The signal flow is now:
SplitAreahasvisibleandsizeSplitcreates_visibleAreasbased onSplitAreavisibleSplitcreates_alignedVisibleAreasSizesbased on_visibleAreasandSplitAreasizewith validation alignmentsSplitArea_internalSizeis based on_alignedVisibleAreasSizes_internalSizeis the actual size anything else should use (except validations and normalizations)