feat: support custom gutter template#360
Merged
beeman merged 1 commit intoangular-split:mainfrom Nov 27, 2023
Merged
Conversation
c14d339 to
bbea59f
Compare
Harpush
commented
Sep 8, 2023
afd35c6 to
5a71e93
Compare
5a71e93 to
16da689
Compare
beeman
reviewed
Nov 17, 2023
ec61b23 to
9a810d5
Compare
9a810d5 to
2337745
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for custom gutter template customization.
There are three main features included:
A new structural directive to allow gutter template customization (
asSplitGutter).The usage as follows:
The new
asSplitGutterdirective allows access to the following context:In case the gutter should have a drag handle allowing dragging only from it, a second directive is introduced -
asSplitGutterDragHandle.The usage is:
In case a certain element inside the gutter should block dragging (a button for example), a third directive is introduced -
asSplitGutterExcludeFromDrag.The usage is:
Implementation notes:
asSplitGutterDragHandlecan be declared on multiple elements which means all of them are drag handles.asSplitGutterExcludeFromDragcan be declared on multiple elements which means all of them are excluded from drag.asSplitGutterExcludeFromDraginsideasSplitGutterDragHandleworks as expected (all of the element is a handle except the excluded area)asSplitGutterDragHandleinsideasSplitGutterExcludeFromDragis ignored and the whole element marked with exclude is excluded.asSplitGuttermostly requireswidth: 100%andheight: 100%in order to fill the whole gutter.gutterSizeinput) the areas will overflow too. So attention is required to match the size of the gutter.Closes #344
Closes #266
Closes #227
Closes #163
Closes #361