fix: include page blur in end events for drag#507
Merged
Jefiozie merged 5 commits intoangular-split:mainfrom May 19, 2025
Akxe:blur-event
Merged
fix: include page blur in end events for drag#507Jefiozie merged 5 commits intoangular-split:mainfrom Akxe:blur-event
Jefiozie merged 5 commits intoangular-split:mainfrom
Akxe:blur-event
Conversation
Contributor
|
@Akxe Can you update your PR description with some text explaining what problem is fixed by this? |
Contributor
Author
|
@SanderElias like this? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue in drag handling by ensuring that a blur event cancels dragging when the user switches away from the app.
- Updated the rxjs import to include the merge operator.
- Modified the drag termination logic to also cancel on a document blur event.
SanderElias
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a blur event handler when dragging is in progress will prevent the user from switching from the app, letting go of the mouse and coming back with the ability to start a new secondary drag, or performing similar actions that were not expected to be possible.