Skip to content

fix: change default area size from null to *#358

Merged
beeman merged 1 commit intoangular-split:mainfrom
Harpush:fix-default-size-wildcard
Sep 5, 2023
Merged

fix: change default area size from null to *#358
beeman merged 1 commit intoangular-split:mainfrom
Harpush:fix-default-size-wildcard

Conversation

@Harpush
Copy link
Collaborator

@Harpush Harpush commented Sep 5, 2023

Currently we don't support more than a single wildcard - but if no area size was provided or wrong area sizes the default logic in percent mode for example is splitting the size equally (kind of multiple wildcards).

This change make split areas without size work again even though this is invalid. The problem can be seen in the collapse example which has no tests coverage (another issue for another time).

We should think how to handle it - size required? Support multiple wildcards?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants