fix: change default area size from null to *#358
Merged
beeman merged 1 commit intoangular-split:mainfrom Sep 5, 2023
Merged
Conversation
This was referenced Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we don't support more than a single wildcard - but if no area size was provided or wrong area sizes the default logic in percent mode for example is splitting the size equally (kind of multiple wildcards).
This change make split areas without size work again even though this is invalid. The problem can be seen in the collapse example which has no tests coverage (another issue for another time).
We should think how to handle it - size required? Support multiple wildcards?