fix(seed): rename index.html to app.html to fix CRSF and token issues

daraosn · daraosn · commit 2e784bf22a4d · 2017-07-27T03:29:10.000+01:00
diff --git a/docs/content/developing/index.md b/docs/content/developing/index.md
@@ -75,10 +75,10 @@ Time: 16538ms
       app.bundle.js.map  3.34 MB       0  [emitted]  app
 polyfills.bundle.js.map   271 kB       1  [emitted]  polyfills
    vendor.bundle.js.map  3.06 MB       2  [emitted]  vendor
-   ../client/index.html  1.39 kB          [emitted]
-Child html-webpack-plugin for "..\client\index.html":
+   ../client/app.html  1.39 kB          [emitted]
+Child html-webpack-plugin for "..\client\app.html":
                    Asset     Size  Chunks       Chunk Names
-    ../client/index.html  2.69 kB       0
+    ../client/app.html  2.69 kB       0
 webpack: bundle is now VALID.
 ```
 
diff --git a/docs/content/get-started/overview.md b/docs/content/get-started/overview.md
@@ -35,7 +35,7 @@ webpack.make.js // main file for Webpack configuration
 ```
 &#9474;   .eslintrc // eslint config for client files
 &#9474;   polyfills.js // imports of polyfills
-&#9474;   _index.html // template for the root HTML file of your app
+&#9474;   app.template.html // template for the root HTML file of your app
 &#9474;
 &#9500;&#9472;&#9472;&#9472;app
 &#9474;   &#9474;   app.config.js // contains app-wide configuration code
diff --git a/src/test/get-expected-files.js b/src/test/get-expected-files.js
@@ -49,7 +49,7 @@ export function app(options) {
     'client/.htaccess',
     'client/favicon.ico',
     'client/robots.txt',
-    'client/_index.html',
+    'client/app.template.html',
     `client/polyfills.${script}`,
     'client/app/app.' + script,
     'client/app/app.config.' + script,
diff --git a/templates/app/_.gitignore b/templates/app/_.gitignore
@@ -4,7 +4,7 @@ public
 .sass-cache<% } %>
 .idea
 client/bower_components
-client/index.html
+client/app.html
 dist
 /server/config/local.env.js
 npm-debug.log
diff --git a/templates/app/client/app.template.html b/templates/app/client/app.template.html
diff --git a/templates/app/gulpfile.babel.js b/templates/app/gulpfile.babel.js
@@ -36,7 +36,7 @@ const paths = {
         styles: [`${clientPath}/{app,components}/**/*.<%= styleExt %>`],
         mainStyle: `${clientPath}/app/app.<%= styleExt %>`,
         views: `${clientPath}/{app,components}/**/*.<%= templateExt %>`,
-        mainView: `${clientPath}/index.html`,
+        mainView: `${clientPath}/app.html`,
         test: [`${clientPath}/{app,components}/**/*.{spec,mock}.<%= scriptExt %>`],
         e2e: ['e2e/**/*.spec.js']
     },
diff --git a/templates/app/server/config/seed(models).js b/templates/app/server/config/seed(models).js
@@ -31,7 +31,7 @@ export default function seedDatabaseIfNeeded() {
           name: 'Smart Build System',
           info: 'Build system ignores `spec` files, allowing you to keep '
                 + 'tests alongside code. Automatic injection of scripts and '
-                + 'styles into your index.html'
+                + 'styles into your app.html'
         }, {
           name: 'Modular Structure',
           info: 'Best practice client and server structures allow for more '
diff --git a/templates/app/server/routes.js b/templates/app/server/routes.js
@@ -17,9 +17,9 @@ export default function(app) {
   app.route('/:url(api|auth|components|app|bower_components|assets)/*')
    .get(errors[404]);
 
-  // All other routes should redirect to the index.html
+  // All other routes should redirect to the app.html
   app.route('/*')
     .get((req, res) => {
-      res.sendFile(path.resolve(app.get('appPath') + '/index.html'));
+      res.sendFile(path.resolve(app.get('appPath') + '/app.html'));
     });
 }
diff --git a/templates/app/webpack.make.js b/templates/app/webpack.make.js
@@ -318,13 +318,13 @@ module.exports = function makeWebpackConfig(options) {
         }));
     }
 
-    // Skip rendering index.html in test mode
+    // Skip rendering app.html in test mode
     // Reference: https://github.com/ampedandwired/html-webpack-plugin
-    // Render index.html
+    // Render app.html
     if(!TEST) {
         let htmlConfig = {
-            template: 'client/_index.html',
-            filename: '../client/index.html',
+            template: 'client/app.template.html',
+            filename: '../client/app.html',
             alwaysWriteToDisk: true
         }
         config.plugins.push(

-Original file line number
+Diff line change
 ```
 │   .eslintrc // eslint config for client files
 │   polyfills.js // imports of polyfills
 -│   _index.html // template for the root HTML file of your app
 +│   app.template.html // template for the root HTML file of your app
 │
 ├───app
 │   │   app.config.js // contains app-wide configuration code