fix(compiler): Don't bind inputs/outputs for data- attributes
#66315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to improve consistency and match developer expectations. This syntax was already deprecated a long time ago. If you want to bind a data attribute, use the `attr.` prefix (which was already supported). BREAKING CHANGE: data prefixed attribute no-longer bind inputs nor outputs. fixes angular#26406
JeanMeche
added
target: major
angular-robot
bot
added
detected: breaking change
JeanMeche
added
breaking changes
and removed
detected: breaking change
Member
Author
|
G3 has been cleaned-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to improve consistency and match developer expectations.
This syntax was already deprecated a long time ago.
If you want to bind a data attribute, use the
attr.prefix (which was already supported).Examples like following will now produce a compilation error:
And should be replace by their respective input syntax (without the
data-prefix)BREAKING CHANGE: data prefixed attribute no-longer bind inputs nor outputs.
fixes #26406
What still works:
bind-foo="someProp"bindssomPropto the foo inputon-foo="fooMethod()"will hook up a listener withfooMethod