feat(core): update AnimationCallbackEvent.animationComplete signature #65616
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
Member
|
This is actually a breaking change that we can't land until we're in a breaking change window again. |
Author
|
@JeanMeche Ok, I updated the description, should I do anything more ? |
Member
|
There isn't much to do until late febuary, our next breaking change window for v22. |
goulaheau
force-pushed
the
feat/65613-animation-complete-signature
branch
from
9d73624 to
85542ad
Compare
…ature BREAKING CHANGE: change AnimationCallbackEvent.animationComplete signature Fixes angular#65613
goulaheau
force-pushed
the
feat/65613-animation-complete-signature
branch
from
85542ad to
3820669
Compare
angular-robot
bot
added
the
detected: breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65613
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The Function type is not precise enough and is in error with this rule :
https://typescript-eslint.io/rules/no-unsafe-call/
Issue Number: #65613
What is the new behavior?
The Function is replaced for () => void, which is more precise.
Does this PR introduce a breaking change?
Other information