Skip to content

more deps grouping#6931

Merged
youknowone merged 1 commit intoRustPython:mainfrom
youknowone:todo-grouping
Feb 1, 2026
Merged

more deps grouping#6931
youknowone merged 1 commit intoRustPython:mainfrom
youknowone:todo-grouping

Conversation

@youknowone
Copy link
Member

@youknowone youknowone commented Feb 1, 2026

Summary by CodeRabbit

  • Chores
    • Enhanced test coverage organization and dependency mapping for core modules including compile, math, float, zipfile, smtplib, profile, string, os, and concurrent frameworks. Reorganized test groupings for improved maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 1, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The PR expands the DEPENDENCIES mapping in scripts/update_lib/deps.py by adding numerous test entries to existing modules (int, pickle, weakref, codecs, ast, xml, multiprocessing, collections, dbm) and introducing new module groupings (compile, math, float, zipfile, smtplib, profile, string, os, pyrepl, concurrent, sysconfig, tkinter) with associated test files and hard dependencies.

Changes

Cohort / File(s) Summary
Dependency Mapping Expansion
scripts/update_lib/deps.py
Expanded DEPENDENCIES dictionary with new test entries for existing modules (int, pickle, weakref, codecs, ast, xml, multiprocessing, collections, dbm) and introduced new module groupings (compile, math, float, zipfile, smtplib, profile, string, os, pyrepl, concurrent, sysconfig, tkinter) each with corresponding test files and hard dependencies. Reorganized concurrent tests and added system-level module support.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • moreal
  • ShaharNaveh

Poem

🐰 With whiskers twitching, I compile with glee,
Test entries grouped from sea to sea!
New modules mapped with care so fine,
Dependency trees in perfect line. ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone marked this pull request as ready for review February 1, 2026 08:01
@youknowone youknowone merged commit 0546bb0 into RustPython:main Feb 1, 2026
12 of 13 checks passed
@youknowone youknowone deleted the todo-grouping branch February 1, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant