Skip flakey test #6453
Skip flakey test #6453
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| # TODO: RUSTPYTHON | ||
| @unittest.expectedFailure | ||
| @unittest.skipIf(mswindows, 'TODO: RUSTPYTHON; Flakey') |
There was a problem hiding this comment.
| @unittest.skipIf(mswindows, 'TODO: RUSTPYTHON; Flakey') | |
| @unittest.skip("TODO: RUSTPYTHON, Flakey") |
since the very next line is @unittest.skipUnless(mswindows, "Maybe test trigger a leak on Ubuntu")
There was a problem hiding this comment.
If CPython decides in a future version to test it on Linux/Darwin, I'd rather not skip it.
Also, regarding the convention of TODO: RUSTPYTHON... if it's separated by ; or , it's not consistent ATM. but I went with ; because that's what https://github.com/RustPython/RustPython/blob/adc2b0dbbe043095be17c037e3daa39b5351c96c/scripts/lib_updater.py does. I prefer the convention of TODO(RUSTPYTHON): ..., but our scripts would need to be adjusted accordingly.
One more thing regarding the single/double quotes is that tool is using ast.unparse under the hood which generates string with single quotes (that's why I wrote it here with single quotes)
There was a problem hiding this comment.
If CPython decides in a future version to test it on Linux/Darwin, I'd rather not skip it.
Good point, noted.
Also, regarding the convention of
TODO: RUSTPYTHON...if it's separated by;or,it's not consistent ATM. but I went with;because that's what https://github.com/RustPython/RustPython/blob/adc2b0dbbe043095be17c037e3daa39b5351c96c/scripts/lib_updater.py does. I prefer the convention ofTODO(RUSTPYTHON): ..., but our scripts would need to be adjusted accordingly.One more thing regarding the single/double quotes is that tool is using
ast.unparseunder the hood which generates string with single quotes (that's why I wrote it here with single quotes)
In the past, when the testdata job in .github/workflows/cron-ci.yaml actually worked, a Liquid/Jekyll template would parse the resulting JSON file and this line of code would strip away the TODO: RUSTPYTHON note and, optionally, a comma or a colon. It seems like something that needs a facelift anyway.
By the way, the reason for #6410 is so that I can have the test suite output an XML file so that (hopefully) it could be converted to something that the RustPython website infrastructure can understand.
There was a problem hiding this comment.
I see, may I suggest another website infrastructure such as Hugo which has many themes, and supports multi-language blog posts&docs. We can auto generate a JSON file/markdown table(s) that the site will read and display. Hugo supports custom HTML OOB, so you can be as flexible as you want (and many other features)
3 participants
That test passed at #6452 which only added a test to
extra_tests