Skip to content

Update test_zipfile64.py from 3.13.11 #6433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Dec 16, 2025
Merged

Update test_zipfile64.py from 3.13.11 #6433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00694d1
Update `test_zipfile64.py` from 3.13.11
ShaharNaveh Dec 13, 2025
be4932b
Merge remote-tracking branch 'upstream/main' into update-test-zipfile64
ShaharNaveh Dec 16, 2025
83ef28b
Mark flaky test
ShaharNaveh Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/test/test_import/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,7 @@ def test_issue31492(self):
with self.assertRaises(AttributeError):
os.does_not_exist

@unittest.skipIf(sys.platform == 'win32', 'TODO: RUSTPYTHON; Flaky')
@threading_helper.requires_working_threading()
def test_concurrency(self):
# bpo 38091: this is a hack to slow down the code that calls
Expand Down
13 changes: 5 additions & 8 deletions Lib/test/test_zipfile64.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
'test requires loads of disk-space bytes and a long time to run'
)

import zipfile, os, unittest
import zipfile, unittest
import time
import sys

Expand All @@ -32,10 +32,6 @@ def setUp(self):
line_gen = ("Test of zipfile line %d." % i for i in range(1000000))
self.data = '\n'.join(line_gen).encode('ascii')

# And write it to a file.
with open(TESTFN, "wb") as fp:
fp.write(self.data)

def zipTest(self, f, compression):
# Create the ZIP archive.
with zipfile.ZipFile(f, "w", compression) as zipfp:
Expand Down Expand Up @@ -67,6 +63,9 @@ def zipTest(self, f, compression):
(num, filecount)), file=sys.__stdout__)
sys.__stdout__.flush()

# Check that testzip thinks the archive is valid
self.assertIsNone(zipfp.testzip())

def testStored(self):
# Try the temp file first. If we do TESTFN2 first, then it hogs
# gigabytes of disk space for the duration of the test.
Expand All @@ -85,9 +84,7 @@ def testDeflated(self):
self.zipTest(TESTFN2, zipfile.ZIP_DEFLATED)

def tearDown(self):
for fname in TESTFN, TESTFN2:
if os.path.exists(fname):
os.remove(fname)
os_helper.unlink(TESTFN2)


class OtherTests(unittest.TestCase):
Expand Down
Loading