Dict keys isdisjoint #3437
Merged
Dict keys isdisjoint #3437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This seems work properly as |
youknowone
previously approved these changes
Nov 15, 2021
Contributor
Author
|
I will get the tests passing and resubmit. @Snowapril would you like me to add a TODO to come back and update this implementation after #3316 is merged? |
Contributor
|
@rvsampson94 Oh yes of course. but rather than that, you could add TODO comment in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of issue #2898.
After this and pull request #3421 are merged, issue #2898 will be resolved.