Skip to content

Do not pollute stack when if-expression condition evaluated to False #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coolreader18 merged 1 commit into from
Jul 3, 2019
Merged

Do not pollute stack when if-expression condition evaluated to False #1098

coolreader18 merged 1 commit into from
Jul 3, 2019

Conversation

@mkurnikov
Copy link
Contributor

@mkurnikov mkurnikov commented Jul 3, 2019 •
edited
Loading

Otherwise provided test snippet fails with Unsupported method __call__ because vm tries to make a __call__on the value returned from expression.

@coolreader18 coolreader18 merged commit 96f6646 into RustPython:master Jul 3, 2019
@mkurnikov mkurnikov deleted the pass-if-expression-to-function branch July 3, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkurnikov @coolreader18