Fix Windows CI symlink handling in pylib build.rs

youknowone · claude · youknowone · commit 7371d308f511 · 2026-01-19T23:35:15.000+09:00
On Windows CI with symlink support enabled, the Lib entry is a proper
symlink instead of a text file. The build script now handles both cases:
1. Text file containing relative path (git without symlink support)
2. Proper symlink (git with symlink support)

Co-Authored-By: Claude Opus 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/crates/pylib/build.rs b/crates/pylib/build.rs
@@ -11,15 +11,25 @@ fn main() {
         process_python_libs("./Lib/**/*");
     }
 
-    if cfg!(windows)
-        && let Ok(real_path) = std::fs::read_to_string("Lib")
-    {
-        let canonicalized_path = std::fs::canonicalize(real_path)
-            .expect("failed to resolve RUSTPYTHONPATH during build time");
-        // Strip the extended path prefix (\\?\) that canonicalize adds on Windows
-        let path_str = canonicalized_path.to_str().unwrap();
-        let path_str = path_str.strip_prefix(r"\\?\").unwrap_or(path_str);
-        println!("cargo:rustc-env=win_lib_path={path_str}");
+    if cfg!(windows) {
+        // On Windows, the Lib entry can be either:
+        // 1. A text file containing the relative path (git without symlink support)
+        // 2. A proper symlink (git with symlink support)
+        // We handle both cases to resolve to the actual Lib directory.
+        let lib_path = if let Ok(real_path) = std::fs::read_to_string("Lib") {
+            // Case 1: Text file containing relative path
+            std::path::PathBuf::from(real_path.trim())
+        } else {
+            // Case 2: Symlink or directory - canonicalize directly
+            std::path::PathBuf::from("Lib")
+        };
+
+        if let Ok(canonicalized_path) = std::fs::canonicalize(&lib_path) {
+            // Strip the extended path prefix (\\?\) that canonicalize adds on Windows
+            let path_str = canonicalized_path.to_str().unwrap();
+            let path_str = path_str.strip_prefix(r"\\?\").unwrap_or(path_str);
+            println!("cargo:rustc-env=win_lib_path={path_str}");
+        }
     }
 }
 
