Merged
Conversation
Contributor
Author
|
Github Enforcer opened Task: RK-19777 |
Urook
reviewed
Sep 10, 2023
| import os | ||
| from flask import send_from_directory | ||
|
|
||
| sentry_sdk.init( |
Contributor
There was a problem hiding this comment.
Dont we need to recalculate the hash of the file?
Contributor
Author
There was a problem hiding this comment.
true true, fixed
ElDuderinos
requested review from
EliRookout,
Urook,
nathan454,
omerkoskas and
ron-rookout
Urook
suggested changes
Sep 10, 2023
| from random import randint | ||
| from todos_store import Store | ||
| import sentry_sdk | ||
| from sentry_sdk.integrations.flask import FlaskIntegration |
Contributor
There was a problem hiding this comment.
Oh no,
Just realized our e2es rely on things being in specific lines. So, removing lines will break e2es. Lets leave the removed lines empty insteqd of removing them?
Contributor
Author
There was a problem hiding this comment.
we do e2e with tutorial-python?
Urook
suggested changes
Sep 27, 2023
app.py
Outdated
| @@ -7,17 +7,17 @@ | |||
| from random import randint | |||
| from todos_store import Store | |||
| import sentry_sdk | |||
Contributor
Author
There was a problem hiding this comment.
aha, sorry good catch, removed
Urook
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.