Add exports for syslog api.#5149
Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom Oct 20, 2017
dantraMSFT:libpsl-native/syslog
Merged
Add exports for syslog api.#5149daxian-dbw merged 2 commits intoPowerShell:masterfrom dantraMSFT:libpsl-native/syslog
daxian-dbw merged 2 commits intoPowerShell:masterfrom
dantraMSFT:libpsl-native/syslog
Conversation
iSazonov
reviewed
Oct 18, 2017
| extern "C" void Native_CloseLog() | ||
| { | ||
| closelog(); | ||
| } No newline at end of file |
| #include <syslog.h> | ||
| #include <nativesyslog.h> | ||
|
|
||
| extern "C" void Native_SysLog(int32_t priority, const char* message) |
Collaborator
There was a problem hiding this comment.
Many cpp files in the directory has "//! " comments. If it is best practice please add doc comments.
Contributor
Author
|
@iSazonov, @daxian-dbw, @TravisEz13 FYI: This is blocking the syslog PR and generating a new nuget package. Thanks. |
Member
|
I don't have additional comments except for what @iSazonov has pointed out. |
Contributor
Author
|
@daxian-dbw There are no additional dependencies. |
Collaborator
|
@dantraMSFT I don't see new commit. |
Member
|
@dantraMSFT Can you please address @iSazonov's comments, then the PR can be approved and merged. |
Contributor
Author
|
PR update. D'oh! |
daxian-dbw
approved these changes
Oct 19, 2017
iSazonov
approved these changes
Oct 20, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables calling the syslog apis to support issue #3766
#5144 is dependent on this change and also requires the libpsl-native nuget package to be republished.