[release/v7.4] Move package validation to package pipeline #26417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports #26414 to release/v7.4, moving package validation from the release pipeline to the package pipeline where packages are built. This reorganization allows package validation to run earlier in the process and improves pipeline organization.
Key Changes:
- Moves the
validatePackagesstage fromPowerShell-Release-Official.ymltoPowerShell-Packages-Official.yml - Updates stage dependencies in the release pipeline to remove references to the moved stage
- Adds
setReleaseTagAndChangelogas a dependency for thePublishMsixstage (brought in from master during cherry-pick resolution)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.pipelines/PowerShell-Release-Official.yml |
Removes validatePackages stage and its dependency reference; updates PublishMsix stage dependencies |
.pipelines/PowerShell-Packages-Official.yml |
Adds validatePackages stage that depends on the upload stage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TravisEz13
added
the
CL-BuildPackaging
adityapatwardhan
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26414 to release/v7.4
Triggered by @TravisEz13 on behalf of @TravisEz13
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
Tooling Impact
Moves package validation from the release pipeline to the package pipeline, improving pipeline organization and allowing package validation to run earlier in the process.
Regression
This is an infrastructure improvement to reorganize pipeline stages.
Testing
Verified by:
Risk
High risk due to changes in release pipeline infrastructure, but necessary for better pipeline organization. The change improves maintainability by moving package validation to where packages are built rather than in the release pipeline.
Merge Conflicts
The following file had conflicts during cherry-pick:
.pipelines/PowerShell-Release-Official.ymlLine: 360 (PublishMsix stage dependsOn)
Conflict Type: Multi-line dependency format vs single-line
Root Cause: The conflict arose because commit 5e05175 (authored by Justin Chung @jshigetomi on Oct 9, 2025, titled "Make MSIX publish stage dependent on SetReleaseTagandContainerName stage") added the
setReleaseTagAndChangelogdependency to thePublishMsixstage in master, but this commit was never backported to release/v7.4. This appears to have been a direct commit to master rather than a PR.Original State:
dependsOn: PushGitTagAndMakeDraftPublic(single dependency)dependsOn:with bothsetReleaseTagAndChangelogandPushGitTagAndMakeDraftPublic(multi-line format)Resolution: Accepted the incoming change from master, which includes the
setReleaseTagAndChangelogdependency. This brings the v7.4 branch in line with master's improved stage dependency chain, ensuring MSIX publishing occurs after both the release tag/changelog is set AND the GitHub draft is made public.Manual Changes: None beyond resolving the conflict markers. The
setReleaseTagAndChangelogstage already exists in release/v7.4, so adding it as a dependency is safe and improves the pipeline's execution order.Note: PR 26414's only actual change to this section was removing trailing whitespace from the
dependsOn:line. The additionalsetReleaseTagAndChangelogdependency came along as part of the cherry-pick from master due to commit 5e05175 which was never backported.