[release/v7.4] Optimize/split windows package signing#26413
Merged
TravisEz13 merged 1 commit intoPowerShell:release/v7.4from Nov 10, 2025
Merged
Conversation
Co-authored-by: Copilot <[email protected]>
TravisEz13
added
the
CL-BuildPackaging
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports Windows package signing optimizations from the main branch to release/v7.4, splitting the build and signing workflow into separate stages to improve performance and compliance with OneBranch pipelines.
Key Changes:
- Splits Windows package workflow into separate build and signing stages
- Introduces new
sign.ymltemplate for dedicated signing operations - Refactors
SetVersionVariables.ymlto use extractedset-reporoot.ymltemplate - Removes
UseJsonparameter across multiple templates (standardizing toCreateJson) - Adds parameterization for
ob_restore_phaseacross reusable templates
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
.pipelines/templates/packaging/windows/sign.yml |
New template for Windows package signing (MSI and EXE) |
.pipelines/templates/packaging/windows/package.yml |
Refactored to build-only job, removed signing steps, disabled signing setup |
.pipelines/PowerShell-Packages-Official.yml |
Split windows_package stage into windows_package_build and windows_package_sign |
.pipelines/templates/SetVersionVariables.yml |
Refactored to use set-reporoot.yml template, added ob_restore_phase parameter |
.pipelines/templates/set-reporoot.yml |
New extracted template for setting repository root |
.pipelines/templates/shouldSign.yml |
Added ob_restore_phase parameter |
.pipelines/templates/install-dotnet.yml |
Added ob_restore_phase parameter |
.pipelines/templates/cloneToOfficialPath.yml |
Added validation and ob_restore_phase parameter |
| Multiple template callers | Removed UseJson parameter, standardized to CreateJson only |
.github/instructions/*.instructions.md |
Added comprehensive documentation for OneBranch patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jshigetomi
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26403 to release/v7.4
Triggered by @TravisEz13 on behalf of @TravisEz13
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
Tooling Impact
Optimizes and splits Windows package signing workflow in OneBranch pipelines. Refactors templates to improve modularity and signing phase separation.
Regression
This is a pipeline optimization and refactoring, not fixing a regression.
Testing
Verified by:
Risk
High risk as it modifies build and signing infrastructure across multiple pipeline templates. However, necessary to maintain pipeline consistency with master branch improvements. Changes optimize signing workflow separation which is critical for OneBranch compliance.
Merge Conflicts Resolution
The following files had conflicts during cherry-pick:
.pipelines/templates/SetVersionVariables.yml
.pipelines/templates/packaging/windows/package.yml
.pipelines/MSIXBundle-vPack-Official.yml