Skip to content

[release/v7.5] Github Workflow cleanup#26389

Merged
TravisEz13 merged 1 commit intoPowerShell:release/v7.5from
TravisEz13:backport-26193
Nov 5, 2025
Merged

[release/v7.5] Github Workflow cleanup#26389
TravisEz13 merged 1 commit intoPowerShell:release/v7.5from
TravisEz13:backport-26193

Conversation

@TravisEz13
Copy link
Member

Backport of #26193 to release/v7.5

Triggered by @TravisEz13 on behalf of @TravisEz13

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

Tooling Impact

  • Optional tooling change

This PR removes unused GitHub Actions workflows that are no longer needed. These workflows (AssignPrs, createReminders, markdownLink, markdownLinkDaily, processReminders) were deprecated and replaced by newer implementations.

Additionally, updates security pinning in tools/download.sh and tools/install-powershell.sh to use commit hashes instead of branch names, improving supply chain security per OpenSSF Scorecard requirements.

Regression

  • Yes
  • No

This is a cleanup change removing unused workflows and improving security practices. No regression is being fixed.

Testing

The original PR was tested by verifying that:

  • Removed workflows are no longer in use
  • Remaining workflows function correctly
  • Installation scripts work with the new commit pinning

For this backport:

  • Verified that the same unused workflows exist in release/v7.5 and can be safely removed
  • Confirmed that the security improvements to installation scripts are compatible with release/v7.5

Risk

  • Low
  • Medium
  • High

Risk Assessment: Low

This change has low risk because:

  1. It removes workflows that are unused/deprecated
  2. The installation script changes only update URL pinning for security (functionality unchanged)
  3. No core PowerShell functionality is modified
  4. The changes are purely related to repository automation and tooling

Merge Conflicts Resolution

During cherry-picking, there were modify/delete conflicts for the workflow files being removed:

  • createReminders.yml
  • markdownLink.yml
  • markdownLinkDaily.yml
  • processReminders.yml

These files had different commit hash pins in release/v7.5 compared to main (likely from security updates). Since the PR's intent is to remove these deprecated workflows, all four files were deleted to match the cleanup goal.

Copilot AI review requested due to automatic review settings November 5, 2025 18:24
@TravisEz13 TravisEz13 requested a review from a team as a code owner November 5, 2025 18:24
@TravisEz13 TravisEz13 added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log and removed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Nov 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes several unused workflow files and pins script references to a specific commit hash for improved security, addressing OpenSSF Scorecard requirements.

  • Removes 5 workflow files that are no longer in use (markdown link checking, PR assignment, and reminder workflows)
  • Pins script references in install-powershell.sh and download.sh from master branch to a specific commit hash (26bb188)
  • Fixes trailing whitespace issue in install-powershell.sh

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/install-powershell.sh Pins gitreposubpath to specific commit hash instead of master branch; removes trailing whitespace on line 130
tools/download.sh Pins install script URL to specific commit hash instead of master branch
.github/workflows/processReminders.yml Removes unused reminder processing workflow
.github/workflows/markdownLinkDaily.yml Removes unused daily markdown link verification workflow
.github/workflows/markdownLink.yml Removes unused markdown link checking workflow for PRs
.github/workflows/createReminders.yml Removes unused reminder creation workflow
.github/workflows/AssignPrs.yml Removes unused PR auto-assignment workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TravisEz13 TravisEz13 enabled auto-merge (squash) November 5, 2025 18:43
@TravisEz13 TravisEz13 merged commit ce09a42 into PowerShell:release/v7.5 Nov 5, 2025
32 of 34 checks passed
@TravisEz13 TravisEz13 deleted the backport-26193 branch November 5, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants