Fix R2R for fxdependent packaging #26131
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
added
the
CL-BuildPackaging
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes ReadyToRun (R2R) compilation settings for different PowerShell deployment types by making the settings conditional based on deployment type rather than unconditionally enabled for Release builds.
- Moves
PublishReadyToRunandPublishReadyToRunEmitSymbolssettings from the global Release configuration to deployment-specific property groups - Disables R2R for
FxDependentdeployments while enabling it forFxDependentDeploymentandSelfContaineddeployments - Provides more granular control over R2R behavior based on deployment scenarios
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jshigetomi
approved these changes
Oct 1, 2025
Collaborator
|
LGTM |
Contributor
|
📣 Hey @@adityapatwardhan, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request updates the
PowerShell.Common.propsfile to make thePublishReadyToRunandPublishReadyToRunEmitSymbolssettings conditional based on the deployment type, instead of always enabling them for Release builds. This change improves control over ReadyToRun publishing behavior for different deployment scenarios.Deployment-specific ReadyToRun settings:
FxDependentdeployments, disablesPublishReadyToRunandPublishReadyToRunEmitSymbols.FxDependentDeploymentandSelfContaineddeployments, enablesPublishReadyToRunandPublishReadyToRunEmitSymbols.General build configuration:
PublishReadyToRunandPublishReadyToRunEmitSymbolsin theReleaseconfiguration, relying instead on the deployment-specific settings above.PR Context
Issue introduced by - #25837
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header