UseConsistentIndentation: When non-default options are used, cater for the case of a comment between pipe and newline#1463
Merged
bergmeister merged 8 commits intoPowerShell:masterfrom Apr 28, 2020
Conversation
…r the case of a comment between pipe and newline
rjmholt
reviewed
Apr 27, 2020
Co-Authored-By: Robert Holt <[email protected]>
… into UseConsistentIndentation-CommentBetweenPipeAndNewline
https://github.com/bergmeister/psscriptanalyzer into UseConsistentIndentation-CommentBetweenPipeAndNewline
This reverts commit 226259d.
…rectly insert whitespaces in there)
rjmholt
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixed #1459 so that indentation gets increased for setting values of
IncreaseIndentationForFirstPipelineorIncreaseIndentationAfterEveryPipelineif there is a comment between pipe and newline (the comment caused it not work because it peeked only at the next token when checking for the newline or line continuation token.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.