Changing back to non-zipped compatibility profiles#1179
Merged
JamesWTruher merged 3 commits intoPowerShell:developmentfrom Mar 21, 2019
Merged
Changing back to non-zipped compatibility profiles#1179JamesWTruher merged 3 commits intoPowerShell:developmentfrom
JamesWTruher merged 3 commits intoPowerShell:developmentfrom
Conversation
The size savings aren't there, as the gallery stores modules as nuget files. Also, there was an issue that if you installed into the public location as administrator and then ran as a regular user, a catastrophic failure in analyzer occurred.
bergmeister
approved these changes
Mar 21, 2019
Collaborator
bergmeister
left a comment
bergmeister
left a comment
There was a problem hiding this comment.
I fixed a typo that caused the build failure. Looks good to me.
bergmeister
pushed a commit
to bergmeister/PSScriptAnalyzer
that referenced
this pull request
Mar 22, 2019
* Changing back to non-zipped compatibility profiles The size savings aren't there, as the gallery stores modules as nuget files. Also, there was an issue that if you installed into the public location as administrator and then ran as a regular user, a catastrophic failure in analyzer occurred. * Update build script to copy profiles into place * Fix build by correcting typo in compatibility_profiles directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
We were trying to save space/download time by providing the profiles in a .zip file, but
the size savings aren't there, as the gallery stores modules as .nupkg files.
The .nupkg with the zip file was bigger than just distributing the .json files.
Also, there was a serious issue that if you installed into the public location as administrator and then ran as a regular user, a catastrophic failure in analyzer occurred.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.